-
Notifications
You must be signed in to change notification settings - Fork 370
Add support for OOP in controllers. #402
base: master
Are you sure you want to change the base?
Conversation
Did you run |
I went back and ran npm install. npm test fails with
created a gulp script and it ran all the tests. 34 failed. 33 of them were
and test 7) CLI Global commands convert invalid resourceListing argument (non-existent file) failed expecting true but getting false. |
Maybe there are some developer dependency changes that haven't been synced into the project but both |
Any updates on this? AFAIK this is the only way to use swagger-tools with Typescript right? |
No update. Once I asked the OP to run tests, I never got a response back. |
The swagger-tools router doesn't behave as I suspected so I stopped using it (which made this PR moot for me). We use something similar to the one I posted in the issue: #284 (comment). @Nepoxx This was an issue related to using classes. Typescript was brought up because classes are popular in it. You can still use Typescript with swagger-tools, as long as your exports are plain objects. |
Well, merging this PR isn't an issue so it should behave as you expected once that's done. I was waiting on a json-refs release to merge this but I can expedite it if that helps. |
I'm using a plain object right now (because OOP wasn't working), so it's not a big deal. |
No description provided.