add preserveOrder option to avoid sorting keys #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently swagger-converter sorts all keys to make sure the output is deterministic. In some cases, the order of properties matters. For instance a model that understandably mentions id and name first. For code generation and example generation it helps to keep these properties first. `preserveOrder: true` may help in these cases.
|
@bobvanderlinden Sorry for the super late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently swagger-converter sorts all keys to make sure the output is
deterministic. In some cases, the order of properties matters.
For instance a model that understandably mentions id and name first. For
code generation and example generation it helps to keep these properties
first.
preserveOrder: truemay help in these cases.The current setup for tests was not really made for potentially non-deterministic outputs (which
preserveOrdercould result in). I left out the test for now, let me know what the best course of action is for this, or whether it should be left ignored.