Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useStarkProfile hook #535

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: useStarkProfile hook #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7793f5f
fix: useStarkProfile hook
irisdv Nov 25, 2024
96671c3
fix: format
irisdv Nov 25, 2024
0d21103
Change files
irisdv Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@starknet-react-core-9f910211-3a7a-4994-86fe-7ad4d2aa9aa1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: useStarkProfile hook",
"packageName": "@starknet-react/core",
"email": "[email protected]",
"dependentChangeType": "patch"
}
168 changes: 10 additions & 158 deletions packages/core/src/hooks/use-stark-profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import type { Address } from "@starknet-react/chains";
import { useMemo } from "react";
import {
CairoCustomEnum,
Provider,
type ProviderInterface,
type RawArgsArray,
cairo,
hash,
shortString,
Expand Down Expand Up @@ -36,7 +33,7 @@ export type StarkProfileArgs = UseQueryProps<

/** Value returned by `useStarkProfile` hook. */
export type GetStarkprofileResponse = {
name: string;
name?: string;
/** Metadata url of the NFT set as profile picture. */
profile?: string;
/** Profile picture url. */
Expand All @@ -63,7 +60,6 @@ type Contract = StarknetTypedContract<typeof multicallABI>;
* social networks ids, and proof of personhood a user has set on its starknetid.
* It defaults to the starknet.id naming and identity contracts but different contracts can be
* targetted by specifying their contract addresses
* If address does not have a stark name, it will return "stark"
*
*/
export function useStarkProfile({
Expand Down Expand Up @@ -103,7 +99,6 @@ export function useStarkProfile({
address,
useDefaultPfp,
namingContract,
provider,
network: chain.network,
identityContract,
multicallContract,
Expand Down Expand Up @@ -144,17 +139,13 @@ function queryFn({
useDefaultPfp,
namingContract,
identityContract,
provider,
network,
multicallContract,
}: StarkProfileArgs & {
provider: ProviderInterface;
multicallContract?: Contract;
network?: string;
}) {
return async () => {
throw new Error("Not implemented");
/*
if (!address) throw new Error("address is required");
if (!multicallContract) throw new Error("multicallContract is required");
if (!network) throw new Error("network is required");
Expand All @@ -163,25 +154,18 @@ function queryFn({
const identity = identityContract ?? contracts["identity"];
const naming = namingContract ?? contracts["naming"];

// get decoded starkname
const p = new Provider(provider);
const name = await p.getStarkName(address, naming);

const data = await multicallContract.call("aggregate", [
[
{
execution: staticExecution(),
to: hardcoded(naming),
selector: hardcoded(hash.getSelectorFromName("address_to_domain")),
calldata: [hardcoded(address)],
calldata: [hardcoded(address), hardcoded(0)],
},
{
execution: staticExecution(),
to: hardcoded(naming),
selector:
network === "mainnet"
? hardcoded(hash.getSelectorFromName("domain_to_token_id"))
: hardcoded(hash.getSelectorFromName("domain_to_id")),
selector: hardcoded(hash.getSelectorFromName("domain_to_id")),
calldata: [arrayReference(0, 0)],
},
{
Expand Down Expand Up @@ -266,7 +250,7 @@ function queryFn({
if (Array.isArray(data)) {
const name =
data[0][0] !== BigInt(0)
? starknetId.useDecoded(data[0].slice(1))
? starknetId.useDecoded(data[0].slice(1).map((val) => BigInt(val)))
: undefined;
const twitter =
data[2][0] !== BigInt(0) ? data[2][0].toString() : undefined;
Expand All @@ -287,7 +271,7 @@ function queryFn({
// extract nft_image from profile data
const profilePicture = profile
? profile.includes("base64")
? JSON.parse(atob(profile.split(",")[1].slice(0, -1))).image
? parseBase64Image(profile)
: await fetchImageUrl(profile)
: useDefaultPfp
? `https://starknet.id/api/identicons/${data[1][0].toString()}`
Expand All @@ -307,11 +291,9 @@ function queryFn({
}

throw new Error("Error while fetching data");
*/
};
}

/*
const hardcoded = (arg: string | number) => {
return new CairoCustomEnum({
Hardcoded: arg,
Expand Down Expand Up @@ -342,9 +324,13 @@ const notEqual = (call: number, pos: number, value: number) => {
});
};

const parseBase64Image = (metadata: string): string => {
return JSON.parse(atob(metadata.split(",")[1].slice(0, -1))).image;
};

const fetchImageUrl = async (url: string): Promise<string> => {
try {
const response = await fetch(parseImageUrl(url));
const response = await fetch(url);

if (!response.ok) {
throw new Error("Network response was not ok");
Expand All @@ -363,7 +349,6 @@ const fetchImageUrl = async (url: string): Promise<string> => {
return "Error fetching data";
}
};
*/

type StarknetIdContractTypes = {
[network: string]: {
Expand Down Expand Up @@ -404,139 +389,6 @@ const StarknetIdcontracts: StarknetIdContractTypes = {
},
} as const;

/*
const executeMulticallWithFallback = async (
contract: ContractInterface,
functionName: string,
initialCalldata: RawArgsArray,
fallbackCalldata: RawArgsArray,
) => {
try {
// Attempt the initial call with the new hint parameter
return await contract.call(functionName, [initialCalldata]);
} catch (initialError) {
// If the initial call fails, try with the fallback calldata without the hint parameter
return await contract.call(functionName, [fallbackCalldata]);
}
};

const getStarkProfileCalldata = (
address: string,
namingContract: string,
identityContract: string,
contracts: Record<string, string>,
): {
initialCalldata: RawArgsArray;
fallbackCalldata: RawArgsArray;
} => {
const initialCalldata: RawArgsArray = [];
const fallbackCalldata: RawArgsArray = [];

initialCalldata.push({
execution: staticExecution(),
to: hardcoded(namingContract),
selector: hardcoded(hash.getSelectorFromName("address_to_domain")),
calldata: [hardcoded(address), hardcoded("0")],
});
fallbackCalldata.push({
execution: staticExecution(),
to: hardcoded(namingContract),
selector: hardcoded(hash.getSelectorFromName("address_to_domain")),
calldata: [hardcoded(address)],
});

const calls = [
{
execution: staticExecution(),
to: hardcoded(namingContract),
selector: hardcoded(hash.getSelectorFromName("domain_to_id")),
calldata: [arrayReference(0, 0)],
},
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(hash.getSelectorFromName("get_verifier_data")),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("twitter")),
hardcoded(contracts["verifier"] as string),
hardcoded("0"),
],
},
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(hash.getSelectorFromName("get_verifier_data")),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("github")),
hardcoded(contracts["verifier"] as string),
hardcoded("0"),
],
},
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(hash.getSelectorFromName("get_verifier_data")),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("discord")),
hardcoded(contracts["verifier"] as string),
hardcoded("0"),
],
},
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(hash.getSelectorFromName("get_verifier_data")),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("proof_of_personhood")),
hardcoded(contracts["verifier_pop"] as string),
hardcoded("0"),
],
},
// PFP
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(hash.getSelectorFromName("get_verifier_data")),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("nft_pp_contract")),
hardcoded(contracts["verifier_pfp"] as string),
hardcoded("0"),
],
},
{
execution: staticExecution(),
to: hardcoded(identityContract),
selector: hardcoded(
hash.getSelectorFromName("get_extended_verifier_data"),
),
calldata: [
reference(1, 0),
hardcoded(shortString.encodeShortString("nft_pp_id")),
hardcoded("2"),
hardcoded(contracts["verifier_pfp"] as string),
hardcoded("0"),
],
},
{
execution: notEqual(6, 0, 0),
to: reference(6, 0),
selector: hardcoded(hash.getSelectorFromName("tokenURI")),
calldata: [reference(7, 1), reference(7, 2)],
},
];
initialCalldata.push(...calls);
fallbackCalldata.push(...calls);

return { initialCalldata, fallbackCalldata };
};

*/

const multicallABI = [
{
name: "ComposableMulticallImpl",
Expand Down
Loading