feat:kakarot connectors #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/kakarot-connectors
branch
from
6ee74df
to
a33c592
Compare
fracek
approved these changes
Oct 26, 2024
fracek
requested changes
Oct 26, 2024
Eikix
reviewed
Oct 28, 2024
Eikix
reviewed
Oct 28, 2024
enitrat
force-pushed
the
feat/kakarot-connectors
branch
2 times, most recently
from
d1358cf
to
5502dea
Compare
fracek
reviewed
Oct 29, 2024
packages/core/src/connectors/base.ts
Outdated
| @@ -45,7 +45,9 @@ export abstract class Connector extends EventEmitter<ConnectorEvents> { | |||
| /** Whether connector is already authorized */ | |||
| abstract ready(): Promise<boolean>; | |||
| /** Connect wallet. */ | |||
| abstract connect(): Promise<ConnectorData>; | |||
| abstract connect(parameters?: { | |||
| chainIdHint: bigint; | |||
There was a problem hiding this comment.
Here parameters is optional, but chainIdHint is required. Can you make chainIdHint optional?
fracek
reviewed
Oct 29, 2024
packages/core/src/connectors/base.ts
Outdated
Comment on lines
48
to
50
| abstract connect(parameters?: { | ||
| chainIdHint: bigint; | ||
| }): Promise<ConnectorData>; |
There was a problem hiding this comment.
Suggested change
| abstract connect(parameters?: { | |
| chainIdHint: bigint; | |
| }): Promise<ConnectorData>; | |
| abstract connect(parameters: { | |
| chainIdHint?: bigint; | |
| } = {}): Promise<ConnectorData>; |
Co-authored-by: Francesco Ceccon <[email protected]>
fracek
force-pushed
the
feat/kakarot-connectors
branch
from
5502dea
to
1119b9a
Compare
fracek
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on implementing a wrapper around EVM connectors through Kakarot