Merged
Conversation
|
Visit the preview URL for this PR (updated for commit ef50830): https://oev-docs--pr156-dapp-docs-update-qe9drfbu.web.app (expires Sun, 16 Feb 2025 16:28:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f |
Siegrift
reviewed
Feb 10, 2025
|
|
||
| ## Integration information | ||
|
|
||
| Clicking "Integrate" on a data feed page will display the information needed for a [contract integration.](/dapps/integration/contract-integration.md) |
Collaborator
There was a problem hiding this comment.
It would make sense to mention that switching later is not a problem.
Member
Author
There was a problem hiding this comment.
That will just cause them to skip OEV Rewards and it will be a pain to have them switch later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
@Ashar2shahid @RiVal-cz for visibility
I didn't address @Siegrift 's concerns about not documenting what exactly constitutes the total OEV Rewards number because the docs currently don't refer to this number in any way. Once that goes up on api3.org, I'm planning to add a section discussing that under the OEV Rewards section.