Usability issue with search on main page #412 #429
Conversation
|
check this if the focus is working poroperly , thanks !! |
|
Is there a preview page somewhere we can see this on? Thanks! Also @Paul-TT can you review the change? |
|
I don't have a preview page, but I just added focus on the input. Let @Paul-TT check if it is working properly without interfering with anything. |
|
Hi @GarvitMahhesh and @bproffitt . I'll check this out this morning. |
|
@bproffitt @GarvitMahhesh I pulled the code into a staging branch. The focus doesn't seem to be working. Were you able to test it locally? Also, it looks like the style tags were removed around the styles.css include which is causing the styles to print on the page. You can see the it staged here. https://www-paulfocustest.staged.apache.org/ |
| {% include "styles.css" %} | ||
| </style> |
There was a problem hiding this comment.
Removing the style marker makes the styles display as text.
|
There are several spurious changes which make it hard to see what actually needs to be changed. |
|
Also it looks like the 'searchButton' variable does not correspond with the actual search button, so the click event is applied to the wrong item. |
Fixed an issue on the main page where the cursor wouldn't focus on the input field when clicking the search button. Added focus functionality to ensure the cursor automatically appears in the input field.