[#2725] fix(spark)(partition-split): Add fallback under load-balance mode and fix stale assignment missing callback that caused timeout#2729
Merged
zuston merged 9 commits intoapache:masterfrom Feb 12, 2026
Conversation
…e available under load-balance mode
zuston
changed the title
roryqi
reviewed
Feb 12, 2026
| // 0, 1, 2 | ||
| int idx = (int) (taskAttemptId % (serverSize - 1)) + 1; | ||
| candidate = servers.get(idx); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Actually this is a strategy. Maybe it will better to separate mechanism and strategy.
Member
Author
There was a problem hiding this comment.
This change targets the second-split scenario where all load-balanced servers have already been split.
In this case, we should fall back to selecting a server using the hash-based algorithm.
At the current stage, this approach is sufficient for large-scale partition workloads. Introducing additional mechanisms would add unnecessary complexity without clear benefit.
roryqi
reviewed
Feb 12, 2026
| validBlocks, | ||
| () -> !isValidTask(taskId)); | ||
| // completionCallback should be executed before updating taskToSuccessBlockIds | ||
| // structure to avoid side effect |
Contributor
There was a problem hiding this comment.
Could u elaborate more about side effect?
roryqi
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
fix the #2725 . Finally tracked down and fixed this tricky bug after a thorough investigation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests