Decouple disk from stripe #11737
Draft
Decouple disk from stripe #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
refactor/decouple-disk-from-stripe
branch
from
b76be6e
to
f6b029d
Compare
|
A tricky idea is adding a pointer to the |
masaori335
reviewed
Aug 27, 2024
| @@ -65,6 +65,8 @@ class StripeSM : public Continuation, public Stripe | |||
| { | |||
| public: | |||
| CryptoHash hash_id; | |||
| char *path = nullptr; | |||
| int fd{-1}; | |||
There was a problem hiding this comment.
CacheDisk has path and fd. I start wondering we should just refer them instead of copy it because StripeSM has CacheDisk *.
trafficserver/src/iocore/cache/Cache.cc
Line 291 in d0b6a4b
There was a problem hiding this comment.
Sure enough. We should definitely deduplicate that! Good find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the following variables out of
Stripe:fdpathdiskhash_text