Improve redirect handling #10981
Draft
Improve redirect handling #10981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not permit a 302 to be cached if a redirect is in progress. * Could be more permissive if we remove the check for `HTTP_STATUS_MOVED_TEMPORARILY` in `HttpTransact::is_response_cacheable()` * Refactor HttpSM::is_redirect_required() to make it easier to call when state is incomplete.
elsloo
force-pushed
the
fix_cached_redirect_in_progress
branch
from
88659cc
to
37b6fd0
Compare
|
Changing this PR to a draft until I complete testing and add the AuTests to this PR with a description of what it solves. Without this PR we have corner cases that can lead to a 302 being cached unintentionally, which then leads to secondary problems due to the 302 itself being possibly stuck in cache and served to other caches. |
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
|
[approve ci] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP_STATUS_MOVED_TEMPORARILYinHttpTransact::is_response_cacheable()