THRIFT-5564: Add nodejs tests to github actions #3082
Merged
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where are the github actions status checks? Do they not run on PRs that come from different repositories? |
cameron-martin
force-pushed
the
nodejs-ci
branch
from
d4b23ff to
44c3f26
Compare
cameron-martin
force-pushed
the
nodejs-ci
branch
3 times, most recently
from
975f993 to
08655ad
Compare
cameron-martin
changed the title
cameron-martin
force-pushed
the
nodejs-ci
branch
from
08655ad to
a53765b
Compare
|
@Jens-G can I get another approval on the CI run? Hopefully it'll be fixed now 🤞 |
cameron-martin
force-pushed
the
nodejs-ci
branch
from
a53765b to
64fe5f2
Compare
These tests exist, but don't currently run on github actions. This adds a new job to run these. This also fixes the regression in the tests caused by apache#3014.
cameron-martin
force-pushed
the
nodejs-ci
branch
from
64fe5f2 to
4fca416
Compare
cameron-martin
changed the title
|
cc @jimexist, since it seems you have been working on the conversion to GitHub actions primarily. |
jimexist
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests exist, but don't currently run on github actions. This adds a new job to run these.
This also fixes the regression in the tests caused by #3014.
[skip ci]anywhere in the commit message to free up build resources.