-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4527: Add generic and pluggable hooks for DAGs and task attempts #324
Open
okumin
wants to merge
3
commits into
apache:master
Choose a base branch
from
okumin:TEZ-4527-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+239
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
changed the title
TEZ-4527: Add generic and pluggable hooks for DAGs and task attempts
[WIP] TEZ-4527: Add generic and pluggable hooks for DAGs and task attempts
Dec 18, 2023
okumin
changed the title
[WIP] TEZ-4527: Add generic and pluggable hooks for DAGs and task attempts
TEZ-4527: Add generic and pluggable hooks for DAGs and task attempts
Dec 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
okumin
commented
Dec 18, 2023
*/ | ||
@ConfigurationScope(Scope.DAG) | ||
@ConfigurationProperty | ||
public static final String TEZ_THREAD_DUMP_INTERVAL = "tez.thread.dump.interval"; | ||
public static final String TEZ_THREAD_DUMP_INTERVAL_DEFAULT = "0ms"; | ||
public static final String TEZ_THREAD_DUMP_INTERVAL_DEFAULT = "100ms"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we introduce pluggable hooks, I think we can change the default value. We may remove NOOP_TEZ_THREAD_DUMP_HELPER, too.
This comment was marked as outdated.
This comment was marked as outdated.
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TEZ-4527