Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): Dutch translations for Current datetime filter #31869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christiaan
Copy link

SUMMARY

The translations mistook "current" for "currency" and other random values.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image
After
image

TESTING INSTRUCTIONS

Enable dutch in the config and switch to the language.

LANGUAGES = {
    'en': {'flag': 'us', 'name': 'English'},
    'nl_NL': {'flag': 'nl', 'name': 'Dutch'}
}

Open a datetime filter on a dashboard.

The translations mistook "current" for "currency" and other random values.
@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:dutch labels Jan 15, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@justinpark justinpark requested a review from rusackas January 15, 2025 18:27
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (76d897e) to head (9d0c00b).
Report is 1327 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31869       +/-   ##
===========================================
+ Coverage   60.48%   83.01%   +22.52%     
===========================================
  Files        1931      539     -1392     
  Lines       76236    39066    -37170     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32429    -13685     
+ Misses      28017     6637    -21380     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.84% <ø> (-0.33%) ⬇️
javascript ?
mysql 75.60% <ø> (?)
postgres 75.67% <ø> (?)
presto 53.36% <ø> (-0.45%) ⬇️
python 83.01% <ø> (+19.52%) ⬆️
sqlite 75.14% <ø> (?)
unit 61.05% <ø> (+3.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:dutch i18n Namespace | Anything related to localization size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant