fix(dataset): use sqlglot for DML check #31024
Open
+56
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Use
sqlglot
when getting column metadata for a virtual dataset. We currently usesqlglot
to check for DML in SQL Lab, but when we save a query as a dataset we're still usingsqlparse
.Part of SIP-117.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Run this query in SQL Lab:
This query is flagged incorrectly as DML by
sqlparse
, but not bysqlglot
.After running, save the query as a dataset. It should work, but currently it fails because
sqlparse
flags the query as having DML.ADDITIONAL INFORMATION