-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sunburst): Added some options to adjust Sunburst chart view: innerRadius, outerRadius, donut, showNulls #30987
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After screenshots (or video) of the controls in effect might help. I've started CI, and will hopefully remember to come back and spin up a test deployment if it passes. |
After screenshot was added previously, now I added video also. |
Found bug with cross-filtering. Converting to draft for now. |
Little hint for beginner needed. |
@bwa84 please feel free to address the bug in this PR if it seems doable as a bycatch fix. But if it's a substantial change, having a dedicated PR for it could be advisable. |
Fixed bug when only 1st and top level of sunburst can emit cross-filter (when >2 levels). Selecting other ended with error.
SUMMARY
Added some options to adjust Sunburst chart:
AFTER SCREENSHOT / VIDEO
sunburst_demo.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION