Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Retain colors when color scheme not set #30646

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

geido
Copy link
Member

@geido geido commented Oct 17, 2024

SUMMARY

This PR does the following:

  • It fixes an issue for which colors would sometimes not keep their consistency when leaving and revisiting the Dashboard.
  • It fixes an issue for which charts original color schemes were not tracked making falling back to their origin color scheme impossible when removing the color scheme from the Dashboard.
  • It attempts to fix and re-enable skipped E2E tests that are critical for the coverage of the color consistency implementation.

BEFORE

Color.Consistency.Test.mp4

AFTER

Color.Consistency.Test.1.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard with a color scheme and shared label colors
  2. Edit the Dashboard properties and remove the color scheme
  3. After applying the changes, verify that shared label colors are still respected
  4. For charts that do not share labels, verify their original color scheme is respected
  5. Save and exit the Dashboard by going to the Dashboard lists
  6. Come back again to the same Dashboard you just saved
  7. Make sure colors haven't changed from the previous state

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant