Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(country-map): Rename incorrect Vietnam province name for Country Map #30608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tienhung2812
Copy link

fix(country-map): Rename incorrect Vietnam province name for Country Map

SUMMARY

In country map chart, some Vietnamese province names in the country map chart are incorrect. I'd like to make the necessary corrections.

ISO 3166-2 Current name Correct Name
VN-39 Đông Nam Bộ Đồng Nai
VN-53 Đông Bắc Bắc Kạn
VN-66 Đồng Bằng Sông Hồng Hưng Yên

Source of corrected name: https://en.wikipedia.org/wiki/ISO_3166-2:VN

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before:
    Screenshot 2024-10-15 at 16 51 23
  • After:
    Screenshot 2024-10-15 at 17 43 07

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Incorrect Vietnam province name in Country map #30607
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts Namespace | Anything related to viz types label Oct 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XS viz:charts Namespace | Anything related to viz types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant