-
Notifications
You must be signed in to change notification settings - Fork 216
[#3985] Rename remaining data-explorer UI references to chart #4081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[#3985] Rename remaining data-explorer UI references to chart #4081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR completes the UI refactoring effort by renaming remaining Angular component selectors and test attributes from data-explorer to chart, following the module rename completed in earlier PRs (#3986, #4021). The changes ensure consistent naming throughout the chart-related UI components.
- Updates Angular component selectors from
sp-data-explorer-*tosp-chart-*across all widget and configuration components - Renames one test data-cy attribute from
data-explorer-select-delta-checkboxtochart-select-delta-checkbox - Updates a documentation comment to reference the renamed module
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| abstract-chart-view.directive.ts | Updates comment to reference chart module instead of data-explorer |
| chart-overview.component.html | Updates component selector reference from sp-data-explorer-overview-table to sp-chart-overview-table |
| chart-overview-table.component.ts | Renames component selector from sp-data-explorer-overview-table to sp-chart-overview-table |
| traffic-light-widget.component.ts | Renames component selector from sp-data-explorer-traffic-light-widget to sp-chart-traffic-light-widget |
| traffic-light-widget-config.component.ts | Renames config component selector from sp-data-explorer-traffic-light-widget-config to sp-chart-traffic-light-widget-config |
| time-series-chart-widget-config.component.ts | Renames config component selector from sp-data-explorer-time-series-chart-widget-config to sp-chart-time-series-chart-widget-config |
| table-widget.component.ts | Renames component selector from sp-data-explorer-table-widget to sp-chart-table-widget |
| table-widget-config.component.ts | Renames config component selector from sp-data-explorer-table-widget-config to sp-chart-table-widget-config |
| status-widget.component.ts | Renames component selector from sp-data-explorer-status-widget to sp-chart-status-widget |
| status-widget-config.component.ts | Renames config component selector from sp-data-explorer-status-widget-config to sp-chart-status-widget-config |
| status-heatmap-widget-config.component.ts | Renames config component selector from sp-data-explorer-status-heatmap-widget-config to sp-chart-status-heatmap-widget-config |
| map-widget.component.ts | Renames component selector from sp-data-explorer-map-widget to sp-chart-map-widget |
| map-widget-config.component.ts | Renames config component selector from sp-data-explorer-map-widget-config to sp-chart-map-widget-config |
| indicator-chart-widget-config.component.ts | Renames config component selector from sp-data-explorer-indicator-chart-widget-config to sp-chart-indicator-chart-widget-config |
| indicator-chart-widget-config.component.html | Updates test attribute from data-explorer-select-delta-checkbox to chart-select-delta-checkbox |
| image-widget.component.ts | Renames component selector from sp-data-explorer-image-widget to sp-chart-image-widget |
| image-widget-config.component.ts | Renames config component selector from sp-data-explorer-image-widget-config to sp-chart-image-widget-config |
| heatmap-widget-config.component.ts | Renames config component selector from sp-data-explorer-heatmap-widget-config to sp-chart-heatmap-widget-config |
| gauge-widget-config.component.ts | Renames config component selector from sp-data-explorer-gauge-widget-config to sp-chart-gauge-widget-config |
| correlation-chart-widget-config.component.ts | Renames config component selector from sp-data-explorer-correlation-chart-widget-config to sp-chart-correlation-chart-widget-config |
| echarts-widget.component.ts | Renames base component selector from sp-data-explorer-echarts-widget to sp-chart-echarts-widget |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Purpose
This PR completes the UI refactor from
data-explorertochartby updating all remainingUI references that were not covered by the initial module rename.
The changes ensure consistent naming across the UI by:
sp-data-explorer-*tosp-chart-*time-series, correlation, heatmap, indicator, and shared base widgets)
data-explorerreferences in UI comments and test (data-cy) attributesThis aligns the UI codebase with the already renamed
chartmodule and avoids confusion causedby outdated naming.
Remarks
Related issues:
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no