Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test job #3330

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Test job #3330

wants to merge 2 commits into from

Conversation

salmanaslam25
Copy link

Purpose

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@github-actions github-actions bot added java Pull requests that update Java code pipeline elements Relates to pipeline elements backend Everything that is related to the StreamPipes backend documentation Everything related to documentation testing Relates to any kind of test (unit test, integration, or E2E test). labels Nov 12, 2024
@tenthe tenthe mentioned this pull request Nov 13, 2024
Closed
@tenthe
Copy link
Contributor

tenthe commented Nov 13, 2024

Thanks for implementing this processor!

I have two minor suggestions for improvement:

  • Could we extend it to allow the user to specify how many events should be included in the sum? For example, if the user enters "5," the processor would calculate the sum of the last five events.
  • Also, what do you think about renaming the processor to something like SumProcessor or SummationProcessor to better reflect its function?

Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend documentation Everything related to documentation java Pull requests that update Java code pipeline elements Relates to pipeline elements testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salmanaslam25 @tenthe