[SPARK-53461][PYTHON][DOCS] Clarify pie plot parameter subplots
#52204
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Sep 3, 2025
HyukjinKwon
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Could you fix PySpark docstring failure, @xinrong-meng ?
/__w/spark/spark/python/pyspark/sql/plot/core.py:docstring of pyspark.sql.plot.core.PySparkPlotAccessor.pie:16:Inline strong start-string without end-string.
make: *** [Makefile:35: html] Error 2
|
Thank you @dongjoon-hyun ! Adjusted. |
dongjoon-hyun
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Thank you for updating, @xinrong-meng . +1, LGTM (Pending CIs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clarify pie plot parameter
subplots, documentsubplotsvia kwargsWhy are the changes needed?
Otherwise, all generated subplots will share the same labels from the x column, which may not be obvious to users what
subplotsmeansDoes this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No