[SPARK-53442]Make PrometheusServlet compatible with OpenMetrics #52183
+125
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangzho
force-pushed
the
prometheus
branch
2 times, most recently
from
4542e2f to
b020853
Compare
### What changes were proposed in this pull request? This PR makes PrometheusServlet publish snapshot that's compatible with OpenMetrics ### Why are the changes needed? Adopting OpenMetrics ensures our metrics output is forward-compatible with common observability tools, not only Prometheus, but also OpenTelemetry, Datadog and others. ### Does this PR introduce _any_ user-facing change? This shall still be compatible witrh Prometheus, while adding more compatibility. No direct user facing changes otherwise. ### How was this patch tested? CIs with added unit test ### Was this patch authored or co-authored using generative AI tooling? No
|
@peter-toth - would you mind help review this as well ? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes PrometheusServlet publish snapshot that's compatible with OpenMetrics
Why are the changes needed?
Adopting OpenMetrics ensures our metrics output is forward-compatible with common observability tools, not only Prometheus, but also OpenTelemetry, Datadog and others.
Does this PR introduce any user-facing change?
This shall still be compatible witrh Prometheus, while adding more compatibility. No direct user facing changes otherwise.
How was this patch tested?
CIs with added unit test
Was this patch authored or co-authored using generative AI tooling?
No