[SPARK-53434][SQL] ColumnarRow's get should also check isNullAt #52175
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, ColumnarRow's
getcall didn't checkisNullAt, butUnsafeRow.getdoes.spark/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/SpecializedGettersReader.java
Line 36 in b177b65
And in some cases it's assumed that the
InternalRow.getis null safe, for examplespark/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
Line 377 in 5b2c4cf
We hit it when we extend spark to make it working on columnar data.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually
Was this patch authored or co-authored using generative AI tooling?
No