Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51055][SS][CONNECT] Streaming foreachBatch should call init logic inside a try #49757

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WweiL
Copy link
Contributor

@WweiL WweiL commented Feb 1, 2025

What changes were proposed in this pull request?

So that any error can be propagated to the jvm. Especially the python version issue.

handle_worker_exception would write out a special int to the jvm, and wil be caught here:

val resFromPython = dataIn.readInt()
if (resFromPython != 0) {
val errMessage = PythonWorkerUtils.readUTF(dataIn)
throw streamingPythonRunnerInitializationFailure(resFromPython, errMessage)
}

Why are the changes needed?

Spark Connect improvements

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit test

Was this patch authored or co-authored using generative AI tooling?

No

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants