[SPARK-50707][SQL] Enable casting to/from char/varchar #49340
+237
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
reviewed
Dec 31, 2024
| } | ||
| } | ||
|
|
||
| test("implicitly cast char/varchar into atomics") { |
There was a problem hiding this comment.
If you say atomics, could you add other types as well, other than boolean.
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ToPrettyStringSuite.scala
Outdated
Show resolved
Hide resolved
...alyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/PredicateResolver.scala
Outdated
Show resolved
Hide resolved
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkCharVarcharUtils.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
changed the title
mihailom-db
reviewed
Jan 3, 2025
| return None | ||
| } | ||
| if (!SqlApiConf.get.preserveCharVarcharTypeInfo) { | ||
| return Some(StringType(s1.collationId)) |
There was a problem hiding this comment.
Why not just return s2 as previous behaviour here?
mihailom-db
reviewed
Jan 3, 2025
mihailom-db
reviewed
Jan 3, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionBase.scala
Outdated
Show resolved
Hide resolved
mihailom-db
reviewed
Jan 3, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ToStringBase.scala
Outdated
Show resolved
Hide resolved
mihailom-db
reviewed
Jan 3, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala
Show resolved
Hide resolved
mihailom-db
reviewed
Jan 3, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala
Show resolved
Hide resolved
jovanm-db
force-pushed
the
char_varchar_cast
branch
from
bffb90b to
b6e4d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable casting to/from char/varchar.
Why are the changes needed?
Currently
castdoes not work correctly. It always casts toStringType. This PR enables casting toCharTypeandVarcharType. This only applies whenspark.sql.preserveCharVarcharTypeInfois set totrue.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests in:
CharVarcharTestSuiteCastSuiteBaseWas this patch authored or co-authored using generative AI tooling?
No.