[SPARK-50700][SQL] spark.sql.catalog.spark_catalog supports builtin magic value
#49332
+43
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @yaooqinn @huaxingao please let me know if this approach makes sense, or do you have any other suggestions to allow users to set |
cloud-fan
reviewed
Dec 31, 2024
| .version("3.0.0") | ||
| .stringConf | ||
| .createOptional | ||
| .createWithDefault("builtin") |
There was a problem hiding this comment.
shall we normalize it to lower case? e.g. .transform(_.toLowerCase(Locale.ROOT))
There was a problem hiding this comment.
thanks for suggestion, updated
There was a problem hiding this comment.
sorry I'm wrong... It's class name so we can't lower case it.
Maybe the string comparisons should be case insensitive.
There was a problem hiding this comment.
oh, right, let me change
There was a problem hiding this comment.
@cloud-fan how about now?
cloud-fan
approved these changes
Dec 31, 2024
|
kindly ping @cloud-fan, can we get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a magic value
builtin(and sets it to the default value) forspark.sql.catalog.spark_catalog.Why are the changes needed?
Currently,
spark.sql.catalog.spark_catalogis optional and hasNoneas the default value. Whenspark.sql.catalog.spark_catalog=a.bad.catalog.implis wrongly set inspark-defaults.conf, the user has no way to overwrite it inspark-submit.Note that, explicitly setting it to
o.a.s.sql.execution.datasources.v2.V2SessionCatalogdoes not work either, becauseV2SessionCatalogdoes not have a zero-args constructor.To fix the above issue, similar to what we did for
spark.sql.hive.metastore.jars, just use "builtin" to represent the built-inV2SessionCatalog.Does this PR introduce any user-facing change?
No change for default behavior, and users are allowed to use
spark.sql.catalog.spark_catalog=builtinto setspark_catalogas the built-inV2SessionCatalog.How was this patch tested?
Code in UTs like
are replaced with
Was this patch authored or co-authored using generative AI tooling?
No.