SOLR-16903: Update CLI tools to use java.nio.file.Path instead of java.io.File #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
approved these changes
Nov 22, 2024
| @@ -281,15 +281,15 @@ public void testAppendUrlPath() { | |||
| @Test | |||
| public void testGuessType() { | |||
| File f = new File("foo.doc"); | |||
There was a problem hiding this comment.
total nit pick, but would declaring the File f as a Path p save a .toPath???
There was a problem hiding this comment.
Yes - but I thought it was best to update the test files separately and at a later point.
|
@AndreyBozhko let me know when you feel the PR is ready...! |
|
@epugh Thanks, I think this piece is ready. |
|
Since this is purely a refactoring, skipping CHANGES.txt. I am going to apply this to |
|
@AndreyBozhko please do tag me as you keep doing these! I also like to keep an eye on https://ci-builds.apache.org/job/Solr/job/Solr-Test-main/ to make sure things remain good as these changes are made! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16903
Description
I would like to work on SOLR-16903 - this PR only addresses part of it.
Here, I'm migrating the CLI tools from using
java.io.Filetojava.nio.file.PathAPIs.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.