-
Notifications
You must be signed in to change notification settings - Fork 666
Add the JDK 25 support #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add the JDK 25 support #783
Conversation
|
This is not related to the issue. The JVM25 adoption is about OAP side. |
|
Compiling passed. We at least need one plugin test to verify the plugin works on JVM25, e.g. a spring case. |
|
something wrong, let me check |
|
docker-library/tomcat#334 |
|
The tests are till failing. Could you recheck? |
|
@wu-sheng |
| docker build -t tomcat-curl:10.1.50-jdk25-temurin \ | ||
| -f ./.github/workflows/Dockerfile-tomcat-jdk25-withCurl . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are overwriting the official image tag by a local build, I think we should update plugin test doc, to mention our Tomcat-jdk25 image is different, and how to build that on developer side.
|
Yes, tests passed. I left one comment about how to setup JDK 25 case locally, please update the document or script to make developers convenient locally. |
Updated |


CHANGESlog.