Skip to content

Conversation

@peachisai
Copy link
Contributor

@peachisai peachisai commented Dec 9, 2025

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number.
  • Update the CHANGES log.

@wu-sheng
Copy link
Member

wu-sheng commented Dec 9, 2025

apache/skywalking#13454

This is not related to the issue. The JVM25 adoption is about OAP side.

@apache apache deleted a comment from peachisai Dec 10, 2025
@wu-sheng wu-sheng added this to the 9.6.0 milestone Dec 10, 2025
@wu-sheng wu-sheng added the enhancement New feature or request label Dec 10, 2025
@wu-sheng
Copy link
Member

Compiling passed. We at least need one plugin test to verify the plugin works on JVM25, e.g. a spring case.

@peachisai
Copy link
Contributor Author

something wrong, let me check

@peachisai
Copy link
Contributor Author

docker-library/tomcat#334
Tomcat community stopped including curl in the JDK 22+ images, so the test step fails because the curl command is not available. I have added a new Dockerfile to build an image based on the tomcat-jdk25 image with curl installed.

@wu-sheng
Copy link
Member

The tests are till failing. Could you recheck?

@peachisai
Copy link
Contributor Author

The tests are till failing. Could you recheck?

image

Hi, I tested this in my local environment. Could you please retrigger the tests?
I found that the failed tests are different each time.

@peachisai
Copy link
Contributor Author

peachisai commented Dec 13, 2025

The tests are till failing. Could you recheck?

image

Just now I had re-triggered all tests in my local env, all of them have passed. Maybe we still need to retrigger one or more times.

@peachisai
Copy link
Contributor Author

peachisai commented Dec 14, 2025

@wu-sheng
Hi, could have a review?

Comment on lines +46 to +47
docker build -t tomcat-curl:10.1.50-jdk25-temurin \
-f ./.github/workflows/Dockerfile-tomcat-jdk25-withCurl .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are overwriting the official image tag by a local build, I think we should update plugin test doc, to mention our Tomcat-jdk25 image is different, and how to build that on developer side.

@wu-sheng
Copy link
Member

Yes, tests passed. I left one comment about how to setup JDK 25 case locally, please update the document or script to make developers convenient locally.

@peachisai
Copy link
Contributor Author

have added a new Dockerfile to build an image based on the tomcat-jdk25 image with curl installed.

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants