Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SINGA-500 add onnx example models #638

Merged
merged 1 commit into from
Mar 31, 2020
Merged

SINGA-500 add onnx example models #638

merged 1 commit into from
Mar 31, 2020

Conversation

joddiy
Copy link
Member

@joddiy joddiy commented Mar 25, 2020

No description provided.

@joddiy joddiy marked this pull request as ready for review March 25, 2020 08:34
@joddiy
Copy link
Member Author

joddiy commented Mar 25, 2020

@nudles ready to merge

@joddiy joddiy changed the title SINGA-500 add onnx example modelsupgrade sonnx for nlp and cv models SINGA-500 add onnx example models Mar 25, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2020

This pull request introduces 12 alerts when merging ddcd3e2 into 3e0c036 - view on LGTM.com

new alerts:

  • 12 for Unused import

nudles
nudles reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@nudles nudles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joddiy !
I have added some minor comments.

python/singa/utils.py Outdated Show resolved Hide resolved
examples/onnx/arcface.py Show resolved Hide resolved
examples/onnx/bert/bert-squad.py Outdated Show resolved Hide resolved
examples/onnx/bert/bert-squad.py Outdated Show resolved Hide resolved
examples/onnx/bert/run_onnx_squad.py Show resolved Hide resolved
@joddiy joddiy force-pushed the SINGA-500_v2 branch 2 times, most recently from c226a2c to 5274b04 Compare March 27, 2020 04:59
@joddiy
Copy link
Member Author

joddiy commented Mar 27, 2020

Thanks, @joddiy !
I have added some minor comments.

Done, thanks for reviewing. Please wait for a while, I will check the Matmul with shicong again. After that, we can merge this PR.

@joddiy
Copy link
Member Author

joddiy commented Mar 28, 2020

@nudles ready to merge, please merge #639 firstly.

@nudles
Copy link
Member

nudles commented Mar 31, 2020

Is there any dependency on issue #635 and #634 ?

@joddiy
Copy link
Member Author

joddiy commented Mar 31, 2020

Is there any dependency on issue #635 and #634 ?

#634 has been fixed, I guess you mean #633 and #635, actually, I indeed need shicong to fix them, however, I modify some code within autograd.py, it can run now, although, not so elegant...

maybe later, when shicong has fixed these two issues, I will update the autogard.py then. But for now, the current implementation can still work.

@nudles nudles merged commit 7af810f into apache:dev Mar 31, 2020
@joddiy joddiy deleted the SINGA-500_v2 branch April 9, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nudles nudles nudles left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joddiy @nudles