Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:refactor] Optimize code for shenyu-register-common #5875

Merged
merged 16 commits into from
Jan 20, 2025
Merged

[type:refactor] Optimize code for shenyu-register-common #5875

merged 16 commits into from
Jan 20, 2025

Conversation

po-168
Copy link
Contributor

@po-168 po-168 commented Dec 30, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind moremind added this to the 2.7.1 milestone Jan 2, 2025
Aias00
Aias00 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aias00 Aias00 merged commit 6929e09 into apache:master Jan 20, 2025
44 checks passed
@po-168 po-168 deleted the dev-shenyu-register-common branch January 21, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aias00 Aias00 Aias00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@po-168 @Aias00 @moremind