Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RateLimiter remoteAddress issues Please reply #5340. #5504

Merged
merged 47 commits into from
Jan 24, 2025

Conversation

wlngo
Copy link
Contributor

@wlngo wlngo commented Mar 19, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@wlngo wlngo closed this Mar 19, 2024
@wlngo wlngo reopened this Mar 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 61.49%. Comparing base (1875f71) to head (c3891b1).

Files Patch % Lines
...in/ratelimiter/resolver/RemoteAddrKeyResolver.java 20.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5504      +/-   ##
============================================
- Coverage     61.64%   61.49%   -0.16%     
+ Complexity     8843     8812      -31     
============================================
  Files          1261     1261              
  Lines         39227    39242      +15     
  Branches       3723     3730       +7     
============================================
- Hits          24183    24132      -51     
- Misses        12873    12932      +59     
- Partials       2171     2178       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yu199195
yu199195 previously approved these changes Apr 2, 2024
@yu199195 yu199195 added this to the 2.7.0 milestone Apr 2, 2024
@Aias00 Aias00 changed the title fixed #5340. fixed RateLimiter remoteAddress issues Please reply #5340. Jan 18, 2025
@wlngo
Copy link
Contributor Author

wlngo commented Jan 20, 2025

why not merge it?

@wlngo
Copy link
Contributor Author

wlngo commented Jan 20, 2025

@Aias00

@Aias00
Copy link
Contributor

Aias00 commented Jan 20, 2025

@Aias00

hi. fix the ci error pls

@wlngo
Copy link
Contributor Author

wlngo commented Jan 20, 2025

@Aias00

hi. fix the ci error pls

@Aias00

hi. fix the ci error pls

ci seemed not error.

@Aias00
Copy link
Contributor

Aias00 commented Jan 21, 2025

@Aias00

hi. fix the ci error pls

@Aias00

hi. fix the ci error pls

ci seemed not error.

no, ci is error

@wlngo
Copy link
Contributor Author

wlngo commented Jan 21, 2025

where it it? Can you give me a screenshot? @Aias00

@Aias00
Copy link
Contributor

Aias00 commented Jan 21, 2025

where it it? Can you give me a screenshot? @Aias00

after i merged master, the ci passed 😂

@Aias00 Aias00 requested review from moremind and yunlongn January 21, 2025 06:19
@wlngo
Copy link
Contributor Author

wlngo commented Jan 21, 2025

它在哪里?你能给我截图吗?@Aias00

我merge master之后ci就通过了😂

That might be the master's fault.

@yu199195 yu199195 merged commit b26dda6 into apache:master Jan 24, 2025
44 checks passed
@yu199195 yu199195 modified the milestones: 2.7.0, 2.7.1 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants