Add Doris grammar rules for RECOVER and tests #33436
Conversation
| @@ -411,6 +411,18 @@ restart | |||
| : RESTART | |||
| ; | |||
|
|
|||
| recoverDatabase | |||
| : RECOVER DATABASE databaseName (databaseId | AS newDatabaseName)? | |||
There was a problem hiding this comment.
You can use rule-element-labels instead of the newDatabaseName rule.
| ; | ||
|
|
||
| recoverPartition | ||
| : RECOVER PARTITION partitionName partitionId? (AS newPartitionName)? FROM tableName |
| @Setter | ||
| public abstract class RecoverDatabaseStatement extends AbstractSQLStatement implements DDLStatement { | ||
|
|
||
| private String databaseName; |
There was a problem hiding this comment.
Could you consider using the DatabaseSegment?
| public abstract class RecoverPartitionStatement extends AbstractSQLStatement implements DDLStatement { | ||
|
|
||
| private String partitionName; | ||
|
|
||
| private String partitionId; | ||
|
|
||
| private String databaseName; | ||
|
|
||
| private String newPartitionName; | ||
|
|
||
| private String owner; | ||
|
|
||
| private String tableName; | ||
|
|
||
| } |
There was a problem hiding this comment.
As above, use class types instead of the primitive types.
| import org.apache.shardingsphere.sql.parser.statement.doris.DorisStatement; | ||
|
|
||
| /** | ||
| * Doris create database statement. |
There was a problem hiding this comment.
Please check the code comments.
| /** | ||
| * Doris create database statement. | ||
| */ | ||
| public final class DorisRecoverDatabaseStatement extends RecoverDatabaseStatement implements DorisStatement { |
There was a problem hiding this comment.
Is it possible to reuse this abstract class in other databases? If not, we should consider removing it.
|
https://shardingsphere.apache.org/community/en/involved/conduct/code/#maintenance-conduct Additionally, please update the release notes for 5.5.2-SNAPSHOT. |
|
Hi @shamilv, can you take a look for @iamhucong suggestion? |
|
Hi @strongduanmu |
Fixes #31504 .
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.