Support parsing Doris sql(#31507) #33316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Oct 20, 2024
| ; | ||
| strrightFunction | ||
| : (STRRIGHT | RIGHT) LP_ expr COMMA_ expr RP_ | ||
| ; |
There was a problem hiding this comment.
Please add new line after this systax.
| @@ -284,7 +284,13 @@ installComponent | |||
| ; | |||
|
|
|||
| installPlugin | |||
| : INSTALL PLUGIN pluginName SONAME shardLibraryName | |||
| // : INSTALL PLUGIN pluginName SONAME shardLibraryName | |||
There was a problem hiding this comment.
Please remove this cooment.
| CANCEL : C A N C E L; | ||
| REBALANCE : R E B A L A N C E; | ||
| STRRIGHT : S T R R I G H T; | ||
| YEARWEEK : Y E A R W E E K; |
There was a problem hiding this comment.
Please add new line at the end of file.
| @@ -20,4 +20,7 @@ | |||
| <sql-case id="install_component" value="INSTALL COMPONENT 'file://component1'" db-types="MySQL" /> | |||
| <sql-case id="install_components" value="INSTALL COMPONENT 'file://component1', 'file://component2'" db-types="MySQL" /> | |||
| <sql-case id="install_plugin" value="INSTALL PLUGIN binlog SONAME 'shared_library_name'" db-types="MySQL" /> | |||
|
|
|||
There was a problem hiding this comment.
Please remove useless blank line.
| @@ -20,4 +20,7 @@ | |||
| <sql-case id="install_component" value="INSTALL COMPONENT 'file://component1'" db-types="MySQL" /> | |||
| <sql-case id="install_components" value="INSTALL COMPONENT 'file://component1', 'file://component2'" db-types="MySQL" /> | |||
| <sql-case id="install_plugin" value="INSTALL PLUGIN binlog SONAME 'shared_library_name'" db-types="MySQL" /> | |||
|
|
|||
| <sql-case id="install_plugin_doris" value="INSTALL PLUGIN FROM "http://mywebsite.com/plugin.zip" PROPERTIES( "md5sum " = "73877f6029216f4314d712086a146570 ")" db-types="Doris" /> | |||
|
|
|||
There was a problem hiding this comment.
Please remove useless blank line.
There was a problem hiding this comment.
Thank you for your review. I made some optimizations.
|
Hi @wangyang377, can you solve code conflict? |
of course, I made some optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31507.
Changes proposed in this pull request:
the lead statement is already supported.
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.