Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraalVM Reachability Metadata and corresponding nativeTest for Consul integration #29588

Closed
wants to merge 1 commit into from
Closed

Add GraalVM Reachability Metadata and corresponding nativeTest for Consul integration #29588

wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 28, 2023 •
edited
Loading

For #29052.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the consul-eh branch 4 times, most recently from 6f8e68c to 7c63281 Compare January 1, 2024 13:59
This was referenced Jan 1, 2024
Merged
Closed
@linghengqian linghengqian mentioned this pull request Feb 28, 2024
Open
2 tasks
@linghengqian linghengqian force-pushed the consul-eh branch 3 times, most recently from 0a3dd43 to 212f864 Compare January 7, 2024 07:53
@linghengqian linghengqian force-pushed the consul-eh branch 2 times, most recently from df6a8e2 to 5cf3d2d Compare January 15, 2024 14:51
linghengqian
linghengqian commented Feb 2, 2024
View reviewed changes
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Close this PR as the original implementation is no longer usable and requires additional refactoring.

@linghengqian linghengqian deleted the consul-eh branch February 2, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mode: cluster type: enhancement type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConsulRepositoryTest.assertWatchUpdate unit test are failed on JDK17 with windows
1 participant
@linghengqian