Allow ConsulRawClient
of cluster-mode-repository-consul
to be configured on ports other than 8500
#29419
Labels
ConsulRawClient
of cluster-mode-repository-consul
to be configured on ports other than 8500
#29419
Feature Request
For English only, other languages will not be accepted.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Is your feature request related to a problem?
Describe the feature you would like.
There are design issues with the current implementation of Consul. Refer to https://github.com/apache/shardingsphere/blob/5.4.1/mode/type/cluster/repository/provider/consul/src/main/java/org/apache/shardingsphere/mode/repository/cluster/consul/ConsulRepository.java .
There is a problem with the way
ConsulRawClient
is initialized, which results inserver-lists
not allowing ports to be configured.localhost:62391:8500
. This section lacks corresponding unit tests.This should parse
server-lists
and switch from callingConsulRawClient(String agentHost)
to callingConsulRawClient(String agentHost, int agentPort)
.It is reasonable behavior to allow
ConsulRawClient
ofcluster-mode-repository-consul
to be configured on ports other than8500
.Also, I looked at
com.ecwid.consul.v1.ConsulRawClient
, andserver-lists
is a weird word in a consul client context, since it's actually only possible to connect to a consul instance.The text was updated successfully, but these errors were encountered: