Skip to content

Conversation

@pwrliang
Copy link
Contributor

This pull request implements GPU-based spatial join by using the extension of c/sedona-libgpuspatial. More details are coming soon.

@jiayuasu
Copy link
Member

@pwrliang @paleolimbot the 186 commits here look crazy and all authors of these commits will become authors of this specific PR once merged. Is there a way to fix this?

@jbampton
Copy link
Member

You might be able to rebase and squash commits

@jbampton jbampton marked this pull request as draft December 12, 2025 03:22
@jbampton
Copy link
Member

Pretty sure when a committer merges this PR they can edit the commit message and log and clean it up and delete all the extra co authors. But still this creates extra work and 186 commits is not the usual workflow.

@pwrliang
Copy link
Contributor Author

@jiayuasu @jbampton Sorry for the scary commit history. I'm getting used to using git merge all the time and it brings all the commit history from the main branch. I have rebased the commits.

@jbampton
Copy link
Member

@pwrliang the pre-commit check is failing here

https://github.com/apache/sedona-db/actions/runs/20157117378/job/57861882061?pr=439

pre-commit is really a series of basic and static checks.

So have a quick read of the next two links with some docs on pre-commit:

https://github.com/apache/sedona-db/blob/main/docs/contributors-guide.md#linting

https://github.com/apache/sedona/blob/master/docs/setup/compile.md#pre-commit

Let me know if you need more help getting pre-commit working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants