-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][seatunnel-transforms-v2] LLM transform Support Ollama return format #8550 #8551
base: dev
Are you sure you want to change the base?
Conversation
Good job, please solve the ci error as follows: https://github.com/apache/seatunnel/pull/8551/checks?check_run_id=35781798828 Unable to detect the workflow run for testing the changes in your PR. If you did not enable GitHub Actions in your forked repository, please enable it by clicking the button as shown in the image below. See also Disabling or limiting GitHub Actions for a repository for more details.
Please contact me if you meet any problem, my Linkedin(https://www.linkedin.com/in/davidzollo) or WeChat(davidzollo), please tell me your github id when added. |
Could you add a test case for this? Thanks |
ok, this is my first time to submit an open source project pr. please forgive me |
try { | ||
return OBJECT_MAPPER.convertValue( | ||
parseResponse(responseStr), new TypeReference<List<String>>() {}); | ||
} catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to specify the error here?
eg:
try { return OBJECT_MAPPER.convertValue( parseResponse(responseStr), new TypeReference<List<String>>() {}); } catch (IllegalArgumentException or xxxx e) { try { String result = OBJECT_MAPPER.convertValue( parseResponse(responseStr), new TypeReference<String>() {}); return Collections.singletonList(result); } catch (Exception ex) { xxxxx } }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that better,but origin code were not handling exception here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
i commit a new test case, please check it |
@SplitfireUptown Remember to retry the failure ci |
please help me, i dont konw why doris test case report this error and kafka test case log can not find any error log, but status is fail |
Please retry failed ci. |
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.