Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][seatunnel-transforms-v2] LLM transform Support Ollama return format #8550 #8551

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

SplitfireUptown
Copy link

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@davidzollo davidzollo added the First-time contributor First-time contributor label Jan 19, 2025
@davidzollo
Copy link
Contributor

Good job, please solve the ci error as follows:

https://github.com/apache/seatunnel/pull/8551/checks?check_run_id=35781798828

Unable to detect the workflow run for testing the changes in your PR.

If you did not enable GitHub Actions in your forked repository, please enable it by clicking the button as shown in the image below. See also Disabling or limiting GitHub Actions for a repository for more details.
Create and push an empty commit to trigger the workflow.
It is possible your branch is based on the old dev branch in Apache SeaTunnel, please sync your branch to the latest dev branch. For example as below:

git fetch upstream
git rebase upstream/dev
git push origin YOUR_BRANCH --force
image

Please contact me if you meet any problem, my Linkedin(https://www.linkedin.com/in/davidzollo) or WeChat(davidzollo), please tell me your github id when added.

@Hisoka-X
Copy link
Member

Could you add a test case for this? Thanks

@SplitfireUptown
Copy link
Author

Could you add a test case for this? Thanks

ok, this is my first time to submit an open source project pr. please forgive me

@github-actions github-actions bot removed the document label Jan 20, 2025
try {
return OBJECT_MAPPER.convertValue(
parseResponse(responseStr), new TypeReference<List<String>>() {});
} catch (Exception e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify the error here?
eg:
try { return OBJECT_MAPPER.convertValue( parseResponse(responseStr), new TypeReference<List<String>>() {}); } catch (IllegalArgumentException or xxxx e) { try { String result = OBJECT_MAPPER.convertValue( parseResponse(responseStr), new TypeReference<String>() {}); return Collections.singletonList(result); } catch (Exception ex) { xxxxx } }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that better,but origin code were not handling exception here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

@SplitfireUptown
Copy link
Author

Could you add a test case for this? Thanks

i commit a new test case, please check it

@corgy-w
Copy link
Contributor

corgy-w commented Jan 23, 2025

Could you add a test case for this? Thanks

i commit a new test case, please check it

@SplitfireUptown Remember to retry the failure ci

@SplitfireUptown
Copy link
Author

Could you add a test case for this? Thanks

i commit a new test case, please check it

@SplitfireUptown Remember to retry the failure ci

please help me, i dont konw why doris test case report this error
image

and kafka test case log can not find any error log, but status is fail

@Hisoka-X
Copy link
Member

Please retry failed ci.

@SplitfireUptown
Copy link
Author

Please retry failed ci.

image

need help, i dont konw why doris test case report this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants