[improve][UI] update dependencies && remove useless code #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add running screenshots |
wuchunfu
reviewed
Jun 18, 2024
Comment on lines
-18
to
-35
| import { defineComponent, computed, watch, ref } from 'vue' | ||
| import { useSettingStore } from '@/store/setting' | ||
| import { useThemeStore } from '@/store/theme' | ||
| import themeList from '@/themes' | ||
| import { | ||
| NConfigProvider, | ||
| NMessageProvider, | ||
| NDialogProvider, | ||
| NMessageProvider, | ||
| darkTheme, | ||
| dateZhCN, | ||
| dateEnUS, | ||
| zhCN, | ||
| enUS | ||
| dateZhCN, | ||
| enUS, | ||
| zhCN | ||
| } from 'naive-ui' | ||
| import { useThemeStore } from '@/store/theme' | ||
| import { useSettingStore } from '@/store/setting' | ||
| import type { | ||
| CustomThemeCommonVars, | ||
| ThemeCommonVars | ||
| } from 'naive-ui/es/config-provider/src/interface' | ||
| import { computed, defineComponent, watch } from 'vue' | ||
| import { useI18n } from 'vue-i18n' | ||
| import themeList from '@/themes' | ||
| import type { GlobalThemeOverrides } from 'naive-ui' | ||
| import type { Ref } from 'vue' | ||
| import type { CustomThemeCommonVars, ThemeCommonVars } from 'naive-ui/es/config-provider/src/interface' |
There was a problem hiding this comment.
@baicie I think these are non essential changes that need to be made, and there is no need to format them
wuchunfu
reviewed
Jun 18, 2024
| } | ||
| ) | ||
| } | ||
| ) | ||
| } |
|
Thanks @baicie for raising this PR. |
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide