Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8950] Remove Redundant nullcheck of configPath #8951

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jjastan
Copy link
Contributor

@jjastan jjastan commented Nov 18, 2024

Which Issue(s) This PR Fixes

Fixes #8950

Brief Description

Remove Redundant nullcheck

How Did You Test This Change?

No test.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.67%. Comparing base (163451e) to head (1ab1ede).

Files with missing lines Patch % Lines
...e/rocketmq/container/BrokerContainerProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8951      +/-   ##
=============================================
- Coverage      47.68%   47.67%   -0.02%     
+ Complexity     11752    11746       -6     
=============================================
  Files           1303     1303              
  Lines          91041    91040       -1     
  Branches       11675    11674       -1     
=============================================
- Hits           43413    43399      -14     
- Misses         42267    42273       +6     
- Partials        5361     5368       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove Redundant nullcheck of configPath
4 participants