Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-2220. Skip further tests after leak detected #1193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

After the first test case has failed, the leak detector will fail the following test cases (even if there are no new leaks) since it won't reset the leak trackers. (comment)

We should skip further tests to avoid wasting time.

(I'm guessing JUnit4 tests may not benefit from this, since it's added in a JUnit5 hook method.)

https://issues.apache.org/jira/browse/RATIS-2220

How was this patch tested?

10x10 run of TestRaftWithGrpc, as expected has many failures.

In each case at most 1 test failed with error, various number of other tests were skipped:

[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 8, Time elapsed: 60.854 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 8, Time elapsed: 54.102 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 154.546 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 8, Time elapsed: 56.705 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 9, Time elapsed: 45.134 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 9, Time elapsed: 43.876 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
[ERROR] Tests run: 11, Failures: 0, Errors: 1, Skipped: 8, Time elapsed: 57.373 s <<< FAILURE! - in org.apache.ratis.grpc.TestRaftWithGrpc
...

CI:
https://github.com/adoroszlai/ratis/actions/runs/12445569381

@adoroszlai adoroszlai self-assigned this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant