RANGER-5110: Update the FQDN of users and groups whenever it changes #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eubnara
commented
Jan 22, 2025
| Map<String, String> groupOtherAttrs = groupInfo.getOtherAttrsMap(); | ||
| String groupDN = groupOtherAttrs != null ? groupOtherAttrs.get(UgsyncCommonConstants.FULL_NAME) : null; | ||
|
|
||
| if (StringUtils.isNotEmpty(groupDN) && !sourceGroups.containsKey(groupDN) | ||
| && StringUtils.equalsIgnoreCase(groupOtherAttrs.get(UgsyncCommonConstants.SYNC_SOURCE), currentSyncSource) && | ||
| StringUtils.equalsIgnoreCase(groupOtherAttrs.get(UgsyncCommonConstants.LDAP_URL), ldapUrl)) { | ||
| if (ISHIDDEN.equals(groupInfo.getIsVisible())) { |
There was a problem hiding this comment.
This is bug introduced by typo. Fix it also in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the FQDN of users and groups, usersync doesn't update it properly and if
ranger.usersync.deletes.enabledis true, those users and groups becomes hidden. It should be handled properly.How was this patch tested?
Manual test on private internal Hadoop cluster.