RANGER-5061: security-admin module(common package): update for code readability improvementRanger 5061 common #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadability improvement
pradeepagrawal8184
force-pushed
the
RANGER-5061_master
branch
2 times, most recently
from
a27465e to
8a3d7e9
Compare
kumaab
reviewed
Jan 4, 2025
| @@ -42,22 +37,22 @@ | |||
|
|
|||
| import javax.persistence.OptimisticLockException; | |||
|
|
|||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
| @Component | |||
| public class RangerTransactionSynchronizationAdapter extends TransactionSynchronizationAdapter { | |||
|
|
|||
There was a problem hiding this comment.
According to checkstyle rules, the build should fail on blank line following an open curly brace. Is it not happening?
There was a problem hiding this comment.
No it is not failing for me, i checked again may be for class declaration it is optional.
There was a problem hiding this comment.
@kumaab - fail on checkstyle violation is not enabled in security-admin/pom.xml.
pradeepagrawal8184
force-pushed
the
RANGER-5061_master
branch
from
a1fd5ae to
9632097
Compare
mneethiraj
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes all checkstyle related errors in common package for security-admin module
How was this patch tested?
mvn clean install