fix(plc4j/drivers/s7): fix Camel tries to reconnect immediately because of event order #1879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an ordering issue for the user event listeners. The isConnected method does return false for less than 1ms which causes an exception because the connection is discared immediately, ignoring that it's not fully connected yet.
Camel Plc4XEndpoint.setupConnection()
: Connection is established and waits for thesessionSetupCompleteFuture
to complete.S7HMuxImpl.userEventTriggered()
is called and thesuper.userEventTriggered()
method calls all user event listenersDefaultNettyPlcConnection.getChannelHandler......userEventTriggered()
is called, which completes thesessionSetupCompleteFuture
.Plc4XEndpoint.setupConnection()
method continues and checks ifS7HPlcConnection.isConnected()
but theIS_CONNECTED
was not set yet and so the connection is closed immediatelyS7HMuxImpl.userEventTriggered()
method continues and sets theIS_CONNECTED
By moving the
super.userEventTriggered()
to the end of the method, the order of the above steps changes to 1, 2, 5, 3, 4 and the bug does not happen.Log: