Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for mspec parser and code generator. #1738

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Aug 23, 2024

No description provided.

@splatch splatch force-pushed the generator-hardening branch 2 times, most recently from e5d1782 to a668321 Compare August 23, 2024 17:16
@sruehl
Copy link
Contributor

sruehl commented Aug 24, 2024

as of a668321 this doesnt even build on java :/

@sruehl
Copy link
Contributor

sruehl commented Aug 24, 2024

ok I think I was on the wrong revision e5d1782... nvm

@sruehl
Copy link
Contributor

sruehl commented Aug 24, 2024

@splatch please rebase on current main

@splatch splatch force-pushed the generator-hardening branch 2 times, most recently from 56cca64 to 6580046 Compare September 16, 2024 10:23
@sruehl
Copy link
Contributor

sruehl commented Sep 18, 2024

@splatch careful that you leave it as readAManual field otherwise we have lang collisions in Goland

@sruehl
Copy link
Contributor

sruehl commented Sep 18, 2024

also it seems you reverted stuff by accident with the rebase, not sure why dad got deleted :D

@sruehl
Copy link
Contributor

sruehl commented Sep 18, 2024

as a small background why I used non-technical terms: When you debug that stuff and you stumble over structs named struct it is getting pretty confusing. So the goal there was to avoid to use the codegen terms so it is easier to seperate content from codegen items.

@splatch
Copy link
Contributor Author

splatch commented Sep 18, 2024

I was sure that this A was a typo! I will try to pull back commit from reflog and cherry pick it on top of develop.

@sruehl
Copy link
Contributor

sruehl commented Sep 18, 2024

no worries, just from the looks of it it looks like a failed rebase/merge :)
Afaik this should be the only change in that PR
image

@sruehl
Copy link
Contributor

sruehl commented Sep 18, 2024

maybe the other one above but not sure. Think I got rid of it because of the confusion
image
but if you added that feel free to readd

@splatch
Copy link
Contributor Author

splatch commented Sep 24, 2024

@sruehl I've cherry picked only intended changes, should be better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants