[cdc] Add option to prevent logging of corrupted records #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atallahade
force-pushed
the
prevent_cdc_corrupt_record_logging
branch
from
c3ef625 to
a578d95
Compare
atallahade
changed the title
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
CDC records in a String format, that failed to be converted to their proper Java type, are currently logged. This can be undesirable if the record contains sensitive data or personally identifiable information.
This change allows setting a table option to redact the data from logs.
I could also rename the option to be more generic and not specific to corrupted records, e.g.
cdc.allow-record-loggingLinked issue: close #4290
Tests
Please let me know if it should (and how it can) be tested.
API and Format
Documentation