[core] Introduce ClearConsumersProcedure to clear consumers #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Jan 13, 2025
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
|
@chenxinwei Can you add more information about this procedure in procedures.md? |
xiangyuf
reviewed
Jan 13, 2025
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
xiangyuf
reviewed
Jan 13, 2025
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
xuzifu666
reviewed
Jan 14, 2025
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
wwj6591812
reviewed
Jan 14, 2025
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
wwj6591812
reviewed
Jan 14, 2025
...imon-flink-1.18/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4
Change-Id: I9e6abe5e52c5c35b263e0a709ceb7c00bf3f8a30
Change-Id: I66d3d6a774bcaa20a7c473b053490bfe614a7c95
chenxinwei
force-pushed
the
master_add_clear_consumers_procedure
branch
from
a275241 to
727ba2c
Compare
xiangyuf
reviewed
Jan 19, 2025
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Show resolved
Hide resolved
xiangyuf
reviewed
Jan 19, 2025
...on-flink-common/src/main/java/org/apache/paimon/flink/procedure/ClearConsumersProcedure.java
Outdated
Show resolved
Hide resolved
Change-Id: Id3912c1c2c90a7beaf41fba1d9c35f162ad6d605
|
Change-Id: I2b94e9f7519b36cbd4f2eed8c82a84809ad8643b
|
@JingsongLi @xiangyuf @xuzifu666 @wwj6591812 Could you please take another look? Thanks a lot. |
xiangyuf
reviewed
Jan 21, 2025
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
xiangyuf
reviewed
Jan 21, 2025
paimon-core/src/main/java/org/apache/paimon/consumer/ConsumerManager.java
Outdated
Show resolved
Hide resolved
| * CALL sys.clear_consumers('tableId', 'includingConsumers', 'excludingConsumers') | ||
| * </code></pre> | ||
| */ | ||
| public class ClearConsumersProcedure extends BaseProcedure { |
There was a problem hiding this comment.
Add test for Spark ClearConsumersProcedure.
xuzifu666
reviewed
Jan 23, 2025
Change-Id: I2bbdfb3e81396b0eae0bc7b33449ae46cb8a93ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I05d02f5c48c82d633436260f1ca5f6d0e9ddfcc4
Purpose
Sometimes，we may want to modify the consumerId in a Flink task.However, if we do not delete other consumers that are not actually used at this time, the expired data will not be effectively cleaned up.So I want to support Support clearing all consumers execept specified consumer in the consumer directory.
Linked issue: close #4599
I will introduce the ClearConsumersProcedure to support clearing unspecified consumers, clearing specified consumers, and clearing all consumers in a table.
Tests
Add UT in ConsumerActionITCase.
API and Format
Documentation