-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Supports only execute specified actions during the writing process. #4884
Open
LinMingQiang
wants to merge
1
commit into
apache:master
Choose a base branch
from
LinMingQiang:master-feat-addconf-toskip-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[core] Supports only execute specified actions during the writing process. #4884
LinMingQiang
wants to merge
1
commit into
apache:master
from
LinMingQiang:master-feat-addconf-toskip-action
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
2 times, most recently
from
January 12, 2025 02:30
9d3fcef
to
ed49eb8
Compare
wwj6591812
reviewed
Jan 12, 2025
Thanks for @LinMingQiang prepare this pr. |
xuzifu666
reviewed
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job and left some comments.
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
January 12, 2025 15:37
7250389
to
b3867f8
Compare
+1 |
Zouxxyy
reviewed
Jan 13, 2025
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
January 13, 2025 08:22
b3867f8
to
99dcebd
Compare
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
4 times, most recently
from
January 18, 2025 08:17
0c0573a
to
7cb026d
Compare
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
January 20, 2025 13:03
2d26f9d
to
fd50ccd
Compare
LinMingQiang
changed the title
[core] Supports skipping specified actions during writing.
[core] Supports only execute specified actions in write task.
Jan 20, 2025
LinMingQiang
changed the title
[core] Supports only execute specified actions in write task.
[core] Supports only execute specified actions during the writing process.
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There are several operations during data writing such as
partition-expire
,snapshot-expire
,create-tag
...Currently, these actions are either executed together or not executed at all in the framework.
The purpose of this PR is to supports skipping specified actions during writing.
For example : set
'write.skip-actions'='partition-expire'
, the partition expiration action will be skipped during data writing, butsnapshot-expire
/auto create tag
/full compact
will still execute normally.Linked issue: close #xxx
Tests
API and Format
Documentation