-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] A FileIO API to list files iteratively #4834
Changes from all commits
f712e0c
0114872
66c8006
afb4964
230ed5b
954c5ff
27349d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.fs; | ||
|
||
import java.io.Closeable; | ||
import java.io.IOException; | ||
|
||
/** An iterator for lazily listing remote entries. */ | ||
public interface RemoteIterator<E> extends Closeable { | ||
|
||
/** | ||
* Checks if there are more entries to be iterated. | ||
* | ||
* @return whether there are more elements to be iterated | ||
* @throws IOException - if failed to list entries lazily | ||
*/ | ||
boolean hasNext() throws IOException; | ||
|
||
/** | ||
* Gets the next entry to be iterated. | ||
* | ||
* @return the next entry | ||
* @throws IOException - if failed to list entries lazily | ||
*/ | ||
E next() throws IOException; | ||
|
||
/** | ||
* Closes the iterator and its associated resources. | ||
* | ||
* @throws IOException - if failed to close the iterator | ||
*/ | ||
void close() throws IOException; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we must have this method? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMHO It is possible that a future implementation would rely on contextual resources. It's better we enforce the resource paradigm since day one. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be lazily using
Iterator
?In hasNext or next, we do really
listStatus
for sub directories.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a
FileStatusIterator
interface to allowhasNext
andnext
throwingIOException
while lazy listing.