Skip to content

ORC-2079: Add lz4 codec pool test coverage #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
+8 −1
Closed

ORC-2079: Add lz4 codec pool test coverage #2517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion java/core/src/test/org/apache/orc/TestVectorOrcFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2346,7 +2346,7 @@ public void testCodecPool(Version fileFormat) throws Exception {
WriterOptions opts = OrcFile.writerOptions(conf)
.setSchema(schema).stripeSize(1000).bufferSize(100).version(fileFormat);

CompressionCodec snappyCodec, zlibCodec, zstdCodec;
CompressionCodec snappyCodec, zlibCodec, zstdCodec, lz4Codec;
snappyCodec = writeBatchesAndGetCodec(10, 1000, opts.compress(CompressionKind.SNAPPY), batch);
assertEquals(1, OrcCodecPool.getPoolSize(CompressionKind.SNAPPY));
Reader reader = OrcFile.createReader(testFilePath, OrcFile.readerOptions(conf).filesystem(fs));
Expand Down Expand Up @@ -2375,6 +2375,13 @@ public void testCodecPool(Version fileFormat) throws Exception {
assertEquals(1, OrcCodecPool.getPoolSize(CompressionKind.ZSTD));
assertSame(zstdCodec, codec);

lz4Codec = writeBatchesAndGetCodec(10, 1000, opts.compress(CompressionKind.LZ4), batch);
assertNotSame(zstdCodec, lz4Codec);
assertEquals(1, OrcCodecPool.getPoolSize(CompressionKind.LZ4));
codec = writeBatchesAndGetCodec(10, 1000, opts.compress(CompressionKind.LZ4), batch);
assertEquals(1, OrcCodecPool.getPoolSize(CompressionKind.LZ4));
assertSame(lz4Codec, codec);

assertSame(snappyCodec, OrcCodecPool.getCodec(CompressionKind.SNAPPY));
CompressionCodec snappyCodec2 = writeBatchesAndGetCodec(
10, 1000, opts.compress(CompressionKind.SNAPPY), batch);
Expand Down
Loading