Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert etcd client version #5318

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

style95
Copy link
Member

@style95 style95 commented Aug 29, 2022

Description

This is to fix #5317 by reverting 4007766.
It seems the version of gprc-core module in the ETCD client conflicts with akka-grpc module.

I am curious how it passed all checks in the first place, but anyway it would be the easiest way to resolve it for now.

I think we need to upgrade both modules at once.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95
Copy link
Member Author

style95 commented Aug 29, 2022

ok, I found there are only unit tests in the scheduler CI tests.
This will guarantee the sanity of the critical path of the scheduler.
#5308

@@ -75,7 +75,7 @@ dependencies {
api "io.kamon:kamon-datadog_${gradle.scala.depVersion}:2.1.12"

// for etcd
api "com.ibm.etcd:etcd-java:0.0.21"
api "com.ibm.etcd:etcd-java:0.0.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we can't use higher version forever?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said above, we can upgrade both etcd client and akka-grpc module.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (9be427c) to head (ab25b6f).
Report is 92 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9be427c) and HEAD (ab25b6f). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (9be427c) HEAD (ab25b6f)
12 5
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5318      +/-   ##
==========================================
- Coverage   81.23%   76.19%   -5.05%     
==========================================
  Files         239      239              
  Lines       14242    14242              
  Branches      604      604              
==========================================
- Hits        11570    10851     -719     
- Misses       2672     3391     +719     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@style95 style95 merged commit 740c907 into apache:master Aug 29, 2022
@style95
Copy link
Member Author

style95 commented Aug 29, 2022

I merged it as no activation can be invoked with the current master.

msciabarra pushed a commit to nuvolaris/openwhisk that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchMethodError on ActivationServiceClient
3 participants