-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert etcd client version #5318
Conversation
ok, I found there are only unit tests in the scheduler CI tests. |
@@ -75,7 +75,7 @@ dependencies { | |||
api "io.kamon:kamon-datadog_${gradle.scala.depVersion}:2.1.12" | |||
|
|||
// for etcd | |||
api "com.ibm.etcd:etcd-java:0.0.21" | |||
api "com.ibm.etcd:etcd-java:0.0.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we can't use higher version forever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said above, we can upgrade both etcd client and akka-grpc module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
==========================================
- Coverage 81.23% 76.19% -5.05%
==========================================
Files 239 239
Lines 14242 14242
Branches 604 604
==========================================
- Hits 11570 10851 -719
- Misses 2672 3391 +719 ☔ View full report in Codecov by Sentry. |
I merged it as no activation can be invoked with the current master. |
Description
This is to fix #5317 by reverting 4007766.
It seems the version of gprc-core module in the ETCD client conflicts with akka-grpc module.
I am curious how it passed all checks in the first place, but anyway it would be the easiest way to resolve it for now.
I think we need to upgrade both modules at once.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: