Skip to content

Commit

Permalink
chore: remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgehermo9 committed Jan 5, 2025
1 parent 443c11d commit e7215b4
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions core/src/types/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,6 @@ pub trait Configurator: Serialize + DeserializeOwned + Debug + 'static {
})
}

// TODO: should we split `from_uri` into two functions? `from_uri` and `from_uri_opts`?
// So we can have:
// ```rust
// fn from_uri(uri: &str) -> Result<Self> {...}
// fn from_uri_opts(uri: &str, options: impl IntoIterator<Item = (String, String)>) -> Result<Self> {...}
//```?
// This way, we can reduce the boilerplate of passing an empty iterator and
// `let op = Operator::from_uri("fs:///tmp/test", vec![])?;`
// becomes `let op = Operator::from_uri("fs:///tmp/test")?;` which is simpler.

/// TODO: document this.
fn from_uri(uri: &str, options: impl IntoIterator<Item = (String, String)>) -> Result<Self> {
let parsed_uri = uri.parse::<Uri>().map_err(|err| {
Expand Down

0 comments on commit e7215b4

Please sign in to comment.