pthread: remove enter_critical_section in pthread_mutex #15126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: OS Components
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a reason for the change and identifies a related PR, it lacks crucial information. Here's what's missing:
Therefore, the PR needs substantial revision to meet the stated requirements before it can be properly reviewed. |
anchao
reviewed
Dec 11, 2024
sched/pthread/pthread_mutex.c
Outdated
| @@ -92,7 +98,7 @@ static void pthread_mutex_remove(FAR struct pthread_mutex_s *mutex) | |||
| FAR struct pthread_mutex_s *prev; | |||
| irqstate_t flags; | |||
|
|
|||
| flags = enter_critical_section(); | |||
| flags = spin_lock_irqsave(&g_mutex_spinlock); | |||
There was a problem hiding this comment.
do we really need lock? is mhead list only modified by one thread(rtcb)?
sched/pthread/pthread_mutex.c
Outdated
| * Public Data | ||
| ****************************************************************************/ | ||
|
|
||
| static spinlock_t g_mutex_spinlock = SP_UNLOCKED; |
There was a problem hiding this comment.
move to tcb_s? only need when CONFIG_PTHREAD_MUTEX_UNSAFE isn't true.
There was a problem hiding this comment.
need global lock here, for the instance of mutex might be accessed by multiple threads
reason: We would like to replace the critical section with a small lock. Signed-off-by: hujun5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pthread: remove enter_critical_section in pthread_mutex
reason:
We would like to replace the critical section with a small lock.
This PR requires #14578 to be merged first.
Impact
pthread
Testing
ci ostest